Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/6.0] WasmAppBuilder: publish only once per target framework instead of invoking publish explicitly. #59136

Merged
merged 1 commit into from
Sep 15, 2021
Merged

[release/6.0] WasmAppBuilder: publish only once per target framework instead of invoking publish explicitly. #59136

merged 1 commit into from
Sep 15, 2021

Conversation

radical
Copy link
Member

@radical radical commented Sep 15, 2021 •
edited
Loading

Based on @ericstj's suggestion
#58816 (comment) .

Fixes #58816 .

danmoseley
danmoseley approved these changes Sep 15, 2021
View reviewed changes
Copy link
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really have enough context to approve but this is breaking CI and if this it we should get it merged ASAP

@danmoseley
Copy link
Member

After the validation completes of course. Thanks for fixing..

@radical
Copy link
Member Author

radical commented Sep 15, 2021

I'm hoping that this fixes it!

@radical
WasmAppBuilder: Use $(CopyLocalLockFileAssemblies) instead of
4d2eab4 
.. explcitly invoking `Publish`.

Based on @ericstj's suggestion
dotnet#58816 (comment) .

Fixes dotnet#58816 .
@radical radical mentioned this pull request Sep 15, 2021
Closed
@radical radical changed the title WasmAppBuilder: publish only once per target framework WasmAppBuilder: publish only once per target framework instead of invoking publish explicitly. Sep 15, 2021
@radical radical marked this pull request as ready for review September 15, 2021 08:22
@radical radical changed the title WasmAppBuilder: publish only once per target framework instead of invoking publish explicitly. [release/6.0] WasmAppBuilder: publish only once per target framework instead of invoking publish explicitly. Sep 15, 2021
@marek-safar marek-safar merged commit 5d03338 into dotnet:release/6.0 Sep 15, 2021
@radical radical deleted the fix-wasmappbuilder-6.0 branch September 15, 2021 13:32
@danmoseley
Copy link
Member

Did this break originally get through PR validation just by bad luck?

@radical
Copy link
Member Author

radical commented Sep 15, 2021

Did this break originally get through PR validation just by bad luck?

Yeah, race, and it happened to pass for all the builds that time 😬

@danmoseley danmoseley mentioned this pull request Sep 15, 2021
Merged
radical added a commit to radical/runtime that referenced this pull request Sep 15, 2021
@radical
[release/6.0] WasmAppBuilder: publish only once per target framework …
6111988 
…instead of invoking publish explicitly. (dotnet#59136)

(cherry picked from commit 5d03338)
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danmoseley danmoseley danmoseley approved these changes

@marek-safar marek-safar marek-safar approved these changes

@ericstj ericstj Awaiting requested review from ericstj

@lewing lewing Awaiting requested review from lewing

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

@steveisok steveisok Awaiting requested review from steveisok

Assignees
No one assigned
Labels
area-Build-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@radical @danmoseley @marek-safar